McRitchie Studio

Scout report: request-changes - Request changes: gem release_check remains unregistered/unwrapped; focused release CLI suite is green under Ruby 3.3. Reporter: alex Outcome: request-changes Findings: - Blocker: bin/release.rb:747-752 still runs a gem release_check via sh(rc, '--build') while config/devops_test_suites.yml release_scopes has no gem scope, so gem releases miss start/result telemetry. - Non-blocker: PR #361 also touches bin/release.rb and test/lib/release_cli_test.rb; git merge-tree auto-merges the pair, but conductor should sequence the same-file overlap. Questions: - none Checks: - Ruby 3.3.11 focused run: ruby -Itest test/lib/release_cli_test.rb — 140 runs, 709 assertions, 0 failures. - bin/devops-tests --app mcritchie-studio prints the updated catalog; PR #414 is mergeable with GitHub CI success.

Scout report: request-changes - Request changes: release telemetry misses gem release_check and qa_smoke can mark Live on QA before a blocking post-deploy hook aborts. Reporter: carl Outcome: request-changes Findings: - Blocker: bin/release.rb:749-752 still runs gem release_check via raw sh and config/devops_test_suites.yml:205-254 has no release scope for it, so gem pre-publish tests emit no start/result telemetry. - Blocker: bin/release.rb:1494-1516 records qa_smoke:completed before QA post-deploy hooks run; Release::EVENT_STAGE_STAMPS maps that to qa_deployed, so a failing hook leaves the tracker Live on QA while members stay reviewed. - Non-blocker: PR #361 also touches bin/release.rb and test/lib/release_cli_test.rb; merge-tree is clean both orders, but Steffon should sequence same-file overlap. Questions: - none Checks: - Read AGENTS, Avi pr-review SOP, shared pr-review SOP, README, testing/deployment runbooks, and release conductor docs. - Reviewed task metadata, PR body, changed files, diff, ReleaseEvent/stage semantics, CI, qa-intake, and prior light scout report. - Focused test passed under Ruby 3.3.11: ruby -Itest test/lib/release_cli_test.rb — 140 runs, 709 assertions. - DoR passed from PR worktree; GitHub CI green; local merge-tree with PR #361 clean both orders.

pr-review blocked review: carl: request-changes - Request changes: release telemetry misses gem release_check and qa_smoke can mark Live on QA before a blocking post-deploy hook aborts.; alex: request-changes - Request changes: gem release_check remains unregistered/unwrapped; focused release CLI suite is green under Ruby 3.3.

Rework done on feat/test-scope-telemetry-registry (PR #414): (1) gem_release_check now registered in release_scopes + wrapped through run_test_scope in publish_gem, abort-before-publish preserved; (2) qa_smoke completed deferred into the else branch, recorded only after the blocking QA post-deploy hook returns green (failed on boot failure) — no premature green. Regression tests added for both; full suite + rubocop certified green, CI green.

pr-review request-changes (both reviewers). (1) Gem release_check is unregistered/unwrapped in the release telemetry — register and wrap it. (2) qa_smoke can mark Live on QA before the blocking post-deploy hook aborts — gate the Live stamp behind the post-deploy hook so a hook abort blocks Live. Focused release-CLI suite is green under Ruby 3.3; extend coverage to these paths, then resubmit and post a note that resolves this feedback.

Approved to reviewed (deploy owner, operator-assigned lane). Re-block was a DUPLICATE of already-resolved feedback: verified on PR head 0d125c74 both findings fixed — (1) gem_release_check registered (registry:234) + wrapped via run_test_scope (release.rb:751), abort-before-publish intact; (2) qa_smoke completed deferred to AFTER the blocking run_post_deploy(:qa) (release.rb:1514-1520). GitHub CI green (4 checks); full suite 2941/0. Taking to production via full-cycle.