McRitchie Studio

Avi review approved (shannon primary + carl light, both merge-ready; nil-average blocker verified fixed with regression test, CI green at 82e107d4); ready for Steffon's qa-release sweep.

Avi review approved; ready for Steffon's qa-release sweep.

Avi review approved; ready for Steffon's qa-release sweep.

Avi review approved; ready for Steffon's qa-release sweep. Rates verified against authoritative pricing reference by both reviewers; dor-check STALE was the known tree-fingerprint false positive (recorded cert tree equals origin branch tree ad5a8571). Phase-2 note: per-action path hardcodes cache_creation=0 (documented), parity holds at that scope.

Avi review approved on resubmit; ready for Steffon's qa-release sweep. Round-1 blocker (stream sources outside turbo-frame) verified fixed at head 909b9485 with placement-asserting regression tests; PR #452 undrafted; CI 4/4 green on head.

BLOCKING (shannon primary; carl light approved the model/conductor layer, which is nil-safe - the defect is in the view): app/views/releases/_deployment_average_chart.html.erb:25 - stages.dig(stage[:key], "average_seconds").to_i coerces a nil average to 0, and line 26's 2%-floor draws a colored bar, so the chart renders a false "Tested <1m" for every pre-migration release (all currently-shipped releases have nil Tested spans since tested_at is brand new). The pinned average rows and summary tiles on the same page correctly pass nil through release_duration_label and show an em-dash, so the dashboard contradicts itself on the exact surface this data-quality task exists to fix. FIX: keep nil (drop the .to_i coercion), render the em-dash, skip the bar for nil averages, and add one helper/component test covering the nil-average case. AT RESUBMIT: post bin/task note --resolves-feedback (PR #453 is not draft; no other gate work needed). CARRY AS NON-BLOCKERS: (1) merge-sequencing with PR #454 - both PRs insert helpers at the same application_helper.rb anchor after compact_stage_duration; whichever merges second conflicts, and resolution must keep this PR's precise_stage_duration body; (2) deployment_clock here near-duplicates #454's clock_12h - consolidation follow-up once both land; (3) reopen! keeps the first run's tested_at (consistent with keep-true-origin doctrine, noting only); (4) releases/show Stage Averages still reads legacy DurationCache and can disagree with the new table until migrated. Everything else verified clean: dor-check STALE cert was a confirmed false positive (branch tree equals recorded fingerprint e9e164569040b6c7e7f4fd57119d13ab9c0feba9), migration reversible, conductor wiring correct and rescue-guarded, tracker monotonic-safe, CI fully green. This is a one-line-plus-test rework; resubmit should be quick.

Avi review approved; ready for Steffon's qa-release sweep. Sweep note: PR #454 and PR #453 both edit the same application_helper.rb region (~compact_stage_duration) — merge one, rebase the other before merging the second. Builder nit: checks_run claims promote component tests that do not exist; reword or add one assertion in a follow-up.

Avi review approved; ready for Steffon's qa-release sweep.

BLOCKING (shannon primary; jasper light approved full-page paths): the live stream sources do not follow in-frame filter changes. app/views/agents/activities.html.erb:21 renders agents/activities_live_streams OUTSIDE turbo-frame#aa-activities-frame (frame opens ~line 37), while every filter control (sidebar session toggles, active-filter chips, Clear all, pager) is an in-frame link_to. Frame navigation swaps only frame children, so the initial-load turbo-cable-stream-source tags persist: (1) load unfiltered then click a session filter -> page stays subscribed to the global agents_activities stream and nonmatching payloads still append to the filtered table (acceptance 2 fails); (2) load ?sessions=sess-A then Clear all -> page stays session-only and the unfiltered table misses other sessions' live appends (acceptance 3 fails). The fix works only on full page loads, which is why current tests pass - they assert full-page render output. FIX: move the activities_live_streams render inside the top of the turbo-frame so stream sources swap with filtered content (Turbo connects/disconnects cable sources on insert/remove), and add a test asserting the sources render within turbo-frame#aa-activities-frame. AT RESUBMIT: run gh pr ready 452 (PR is still draft) and post bin/task note --resolves-feedback. NON-BLOCKING nits: empty filtered page renders hb-empty with no thead#aa-activities-head target so the first matching live activity cannot append (pre-existing, fix optional); extra agent_activity PK lookup per action broadcast is acceptable. What is good: dual-broadcast design (global + session streams, single-scope subscription) is sound, and green CI on head a34c0834 supersedes the local SIGTERM full-suite bypass - keep it.

Avi review APPROVED (2/2). Shannon (primary) + Alex (light) both merge-ready, no blockers. CI green on head 9254d743 (test/lint/scan_js/scan_ruby). Idiom parity with people/teams filteredSessions getter confirmed; no dead per-row x-show; compact_time_ago <45→<60 boundary fix + test correct. dor-check cert-MISSING was a wrong-root false positive (PR head tree 0bdcb5a03c3e == recorded cert). Fixed PR-body doc-drift (x-show → filteredSessions getter). Ready for Steffon's qa-release sweep.

Avi review approved; ready for Steffon's qa-release sweep.

PR #12: ModelPage code is clean (Carl + Jasper both found no code defects; admin gate fails closed, no constantize leak, no XSS, route ordering correct) — but three gates block. (1) DoR is RED: no fingerprint-bound full-suite/rubocop cert recorded for this SHA — run bin/full-suite-check model-page-engine-protocol (or a justified [full-suite-bypass] note if bin/release-check is the canonical gem suite). (2) AC#6 unmet: mcritchie consumer CI is RED on AgentWorktreeTest#test_mcritchie_config_reserves_3020 (test/lib/agent_worktree_test.rb:53) — a pre-existing env-brittle test that shells to bin/agent-worktree and dies on 'repo missing: .../mcritchie-studio', unrelated to this diff; library-shape DoR requires BOTH consumer suites green, so guard that test to skip when the sibling mcritchie-studio checkout is absent, or get operator sign-off to except the flake and record a [consumer-ci-flake] note. (3) Re-point PR base from main to release (gh pr edit 12 --base release — same SHA 1671e54, zero drift) to avoid an accidental merge-to-main and keep qa-release-sweep semantics clean. Non-blocking for a follow-up: register-in-initializer guidance will empty the class-level @registry on Zeitwerk dev-reload (point hosts at config.to_prepare); and as_json dumps all columns (add an attribute filter before registering any sensitive model). No ModelPage code changes needed.

Avi review approved (2/2 merge-ready) — ready for Steffon's qa-release sweep. PRIMARY shannon (deep) + LIGHT jasper (light) both approve; CI green on #449 (test/lint/scan_ruby/scan_js). DoR gate genuinely met: head e3dacce0 tree c827cb2ad4b0 == recorded cert tree (dor-check STALE was the known tree-hash false positive). Inclusive union sort verified untouched (activity-only sessions kept, regression-tested); theme parity via --hb-muted; 3-tier coverage. One non-blocking nit both caught: compact_time_ago renders '0m ago' for the 45-59s window (just-now cutoff 45s vs 60s minute floor) — cosmetic, fold into a follow-up push if convenient, not a gate.

pr-review moved standardize-llm-logging to reviewed after carl + alex reported merge-ready. Left for Steffon QA. Reports: - carl: merge-ready - Primary review found no blockers; PR satisfies LLM logging acceptance and is ready for Avi to advance. - alex: merge-ready - Light review found no blockers; Codex/Claude capture, installer wiring, docs, CI, and merge safety look ready.

Code is merge-ready — all 5 acceptance criteria MET, CI green, Claude backward-compat preserved, docs accurate. The block is the DoR gate (evidence recording only, NOT a code rework). Two must-fix items: 1) MALFORMED full-suite/rubocop cert. checks_run has '[full-suite] ... green at 6fa63a721915' / '[rubocop] ... green at 6fa63a721915', but the gate (bin/lib/full_suite_gate.rb EVIDENCE_RE) only accepts the fingerprint INSIDE the brackets: [full-suite@6fa63a721915] / [rubocop@6fa63a721915]. dor-check reports both MISSING — confirmed run from the exact branch tree 6fa63a7219, so this is NOT a stale-cert false positive, the evidence line is unparseable. Fix: run 'bin/full-suite-check standardize-llm-logging' from the branch to stamp valid cert lines. 2) MISSING required tier tags. Backend shape requires [unit] + [integration] tagged checks_run lines; neither present (the tests exist and pass — recording only). Add them. NOTE: bin/task update --checks REPLACES the list, so re-include the valid cert lines AND the tier lines in one update. Fix opportunistically in the same pass (non-blockers, don't merit their own loop): 3) bin/atomic-capture-hook ~L844 outcome_for: a SUCCESSFUL Codex tool whose String output echoes 'Process exited with code N' (N!=0) is mis-flagged ERROR — tighten the match. 4) docs/agents/system/atomic-capture-hook.md polish: add the Codex string-based 'Process exited with code N' signal to the outcome-field row (~:51); mention the new provider-adapter/Codex-normalization/transcript-recovery unit tests in the Tests section (~:291). After re-cert, dor-check will pass — resubmit and post a note --resolves-feedback.

pr-review moved approval-ready-tasks to reviewed after shannon + carl reported merge-ready. Left for Steffon QA. Reports: - shannon: merge-ready - No blockers found; approval wait metadata, sorting, pulse, Local Demo action, and handoff docs match acceptance. - carl: merge-ready - Carl light review found no blockers; approval wait state, board ranking, Local Demo action, and handoff docs align with acceptance.

pr-review blocked review: shannon: request-changes - Request changes: one reduced-motion UI blocker; approval waiting behavior otherwise matches acceptance and gates are green.; carl: merge-ready - Light backend review found no blockers; approval wait metadata, ordering, pulse, Local Demo action, and handoff docs match acceptance.

pr-review moved condense-release-tasks to reviewed after shannon + jasper reported merge-ready. Left for Steffon QA. Reports: - shannon: merge-ready - No blockers found. Current-release card condenses to two highlighted task links with fixed fade slots, cost badges, and repo-count remainder chips; DoR, CI, targeted Rails tests, and Tailwind build are green. - jasper: merge-ready - Light UI second read found the condensed current-release member summary aligned with acceptance; GitHub CI is green at PR head and merge/file-overlap safety is clean.

pr-review deferred approval-ready-tasks: conductor-review. shannon: merge-ready - Primary review found no blockers; approval waiting state, ordering, pulse, Local Demo action, and handoff docs match acceptance with green gates.; carl: conductor-review - Code and local behavior read clean; PR is still draft, so Avi should resolve the readiness mismatch before final gate.

pr-review blocked review: primary found merge-safety conflict with PR #438 in test/helpers/application_helper_test.rb; acceptance and tests are otherwise green, but release sweep can fail depending merge order. Rebase or resolve against the reviewed/queued release work, then resubmit.