McRitchie Studio

Scout report: request-changes - Request changes: static deployments rendering and CI are green, but live Turbo re-rendered assembled cards lose the mascot dual-type gradient. Reporter: shannon Outcome: request-changes Findings: - Blocker: app/services/deployments_broadcaster.rb card_locals does not pass type_enumerals, while app/views/tasks/_task_card.html.erb only sets --task-card-glow-color-b from mascot types when type_enumerals is present; assembled cards broadcast during live stage moves collapse to a one-color gradient until refresh. - Non-blocker: PR #398 is open, targets release, is GitHub-mergeable, and CI is green; it overlaps with open PR #396 on deployments live FX and with #400 in controller tests, so merge sequencing still needs attention after rework. Questions: - none Checks: - Read AGENTS.md, Avi pr-review SOP, pr-review primitive, README, RUNBOOK, frontend/testing/theme docs, and Shannon role. - Inspected task metadata, PR body, changed files, GitHub checks, diff, mergeability, and open-PR file overlap. - GitHub CI passed lint, scan_js, scan_ruby, and test; git diff --check was clean; local http://localhost:3010/up and /deployments returned 200. - Rails runner comparison showed assembled render without type_enumerals emits --task-card-glow-color-a and -b as #EE8130, while full render with type_enumerals emits #EE8130 and #A98FF3.

Primary review found a live Turbo rendering blocker: assembled cards broadcast by app/services/deployments_broadcaster.rb do not receive type_enumerals, while app/views/tasks/_task_card.html.erb only sets the second mascot gradient color from type_enumerals. Static /deployments render is green, but a live assembled transition collapses the dual type-color gradient to one color until refresh. Pass type_enumerals through the broadcast card locals and add regression coverage for the live rendered assembled-card path before resubmitting.

Addressed review feedback: DeploymentsBroadcaster now passes Pokemon.type_enumerals into the live task-card render, and the service regression asserts assembled dual-type broadcasts keep both gradient colors.

Scout report: merge-ready - Light review: acceptance matched, no blockers; CI and focused local checks green, PR mergeable into release. Reporter: jasper Outcome: merge-ready Findings: - Blockers: none. - Non-blocker: prefers-reduced-motion slows assembled/confirming border animation to 42s rather than disabling it; acceptable for this glow-focused PR. - Questions: none. Questions: - none Checks: - PR metadata: base release, head feat/submitted-blocked-glow, mergeable; no unresolved review threads. - CI: gh pr checks 398 all pass (scan_ruby, scan_js, lint, test). - Local focused: Homebrew Ruby PATH prefix + bin/rails test task_card/deployments_live_fx/tasks_controller/deployments_broadcaster -> 125 runs, 781 assertions, 0 failures. - Asset/local: bin/rails tailwindcss:build succeeded; curl /up and /deployments on localhost:3010 returned 200; HTML contains stage glow classes.

Scout report: merge-ready - Merge-ready: rework closes the live broadcast dual-type gradient gap, acceptance criteria are covered, and CI plus focused local checks are green. Reporter: shannon Outcome: merge-ready Findings: - [blockers] None found. - [non-blocker] app/views/tasks/_task_card.html.erb builds submitted, blocked, reviewed, and assembled glow state from validated mascot colors; app/services/deployments_broadcaster.rb now passes type_enumerals so live assembled broadcasts keep dual-type gradients. - [non-blocker] Pairwise merge-tree with PR #396 conflicts in test/views/deployments_live_fx_test.rb; PR #396 is already DIRTY, so this is a conductor sequencing/rebase note rather than a blocker for PR #398. - [questions] None. Questions: - none Checks: - Read AGENTS.md, Avi pr-review SOP, shared pr-review primitive, README, frontend/testing/theme/deployment docs, and Shannon role docs. - Inspected task metadata, PR body, commits, changed files, GitHub review/check status, local diff, and open-PR overlap. - GitHub PR #398 is open, non-draft, MERGEABLE/CLEAN, with scan_ruby, scan_js, lint, and test all passing. - Focused Rails checks passed with Homebrew Ruby path: task_card, deployments_live_fx, deployments_broadcaster, tasks_controller, and board_cleared_block_card tests ran 128 runs / 791 assertions / 0 failures. - bin/dor-check submitted-blocked-glow passed; git diff --check was clean; git merge-tree origin/release HEAD was clean; local http://localhost:3010/up and /deployments returned 200. - Reviewed handoff screenshots and rendered /deployments HTML showing data-stage-glow/CSS vars for submitted, blocked, reviewed, assembled, and confirming release states.

pr-review moved submitted-blocked-glow to reviewed after shannon + jasper reported merge-ready. Left for Steffon QA. Reports: - shannon: merge-ready - Merge-ready: rework closes the live broadcast dual-type gradient gap, acceptance criteria are covered, and CI plus focused local checks are green. - jasper: merge-ready - Light review: acceptance matched, no blockers; CI and focused local checks green, PR mergeable into release.