McRitchie Studio

Scout report: merge-ready - Light review found reviewed/archive animation behavior aligned; CI, DoR, merge-tree, local server, and focused tests are green. No code blockers; note GitHub draft/stack sequencing for conductor. Reporter: alex Outcome: merge-ready Findings: - No blocker: reviewed arrivals branch on data-stage=reviewed and use distinct wake/ribbon effects; archive removals keep the remove stream and use data-exit-action=archive for mist. - Merge safety: merge-tree into origin/release is clean; overlap scan found intentional reviewed stack PRs #389/#394 plus draft/building #395 only in a controller test. - Non-blocker: PR #396 remains marked GitHub draft and is stacked on reviewed PRs #389/#394, so the conductor/QA sweep should clear or sequence the stack deliberately. Questions: - none Checks: - [component/unit/integration] Focused Rails tests passed: deployments_live_fx_test.rb, deployments_broadcaster_test.rb, tasks_controller_test.rb (110 runs, 627 assertions). - [ci] GitHub PR #396 scan_ruby, scan_js, lint, and test all green; mergeStateStatus CLEAN and mergeable MERGEABLE. - [merge-safety] git merge-tree --write-tree origin/release origin/feat/reviewed-mist-animations returned 683890ba071537adc1fdecd4b7a59ce2399c1316 with no conflicts; bin/dor-check reviewed-mist-animations passed. - [browser] Local http://localhost:3013/up returned 200; inspected tmp/reviewed-wake-check-final.png and tmp/archive-mist-check-final.png for wake/ribbons and mist visibility.

Scout report: merge-ready - Primary review: reviewed wake/ribbon arrival and archive mist match acceptance; live stream action contracts remain remove/prepend/replace with archive/delete exit hints; local focused Rails, DoR, Playwright, screenshots, merge-tree, and GitHub CI are green. Reporter: shannon Outcome: merge-ready Findings: - Blockers: none found. - Non-blocker: PR #396 is still GitHub draft and stacked on #389/#394; #394 is also draft, so Avi/QA should undraft and sequence the stack deliberately before merge. - Non-blocker: test/services/deployments_broadcaster_test.rb still stubs broadcast_remove_to in the task_removed guard test even though task_removed now uses broadcast_stream_to; implementation remains inside Studio::Cable.safe_broadcast. - Merge safety: merge-tree into origin/release is clean; open-PR overlap is expected stack files plus unrelated #395 touching only tasks_controller_test among this PR changed files. Questions: - none Checks: - GitHub PR #396 scan_ruby, scan_js, lint, and test all pass; mergeable MERGEABLE, mergeStateStatus CLEAN. - bin/dor-check reviewed-mist-animations passed for ui-only and reports ready to advance submitted -> reviewed. - Focused Rails checks passed with Homebrew Ruby PATH: bin/rails test test/views/deployments_live_fx_test.rb test/services/deployments_broadcaster_test.rb test/controllers/tasks_controller_test.rb test/integration/board_app_filter_test.rb; 112 runs, 659 assertions. - Playwright Chromium check passed on isolated E2E_PORT=3014: npm test -- e2e/task_card_actions.spec.js; test DB reset afterward. - Local http://localhost:3013/up returned 200; inspected tmp/reviewed-wake-check-final.png and tmp/archive-mist-check-final.png for visible wake/ribbons and mist. - git merge-tree --write-tree origin/release origin/feat/reviewed-mist-animations returned 683890ba071537adc1fdecd4b7a59ce2399c1316 with no conflicts.

pr-review moved reviewed-mist-animations to reviewed after shannon + alex reported merge-ready. Left for Steffon QA. Reports: - shannon: merge-ready - Primary review: reviewed wake/ribbon arrival and archive mist match acceptance; live stream action contracts remain remove/prepend/replace with archive/delete exit hints; local focused Rails, DoR, Playwright, screenshots, merge-tree, and GitHub CI are green. - alex: merge-ready - Light review found reviewed/archive animation behavior aligned; CI, DoR, merge-tree, local server, and focused tests are green. No code blockers; note GitHub draft/stack sequencing for conductor.

qa-release sweep could NOT merge this PR (#396) — it CONFLICTS with the current release branch (release advanced past this branch's base while it sat in review; rel-20260705-016f81 just assembled restore-card-title-marquee + reclassify-togepi-and-tyrogue ahead of it). git merge-tree shows conflicts in: app/views/tasks/_board.html.erb (live-board card exit/archive animation — the useLiveExit / animateCardExit branch) and app/services/deployments_broadcaster.rb. This is NOT a code-quality defect — the review approved the code; the branch is simply stale vs release. Action: rebase feat/reviewed-mist-animations onto origin/release, resolve those two conflicts (reconcile the mist animation with the current LiveBoardFx card-exit logic — mind the live-board animation gotchas + dual render paths), re-run CI green, resubmit. The rest of the candidate is assembled and live on QA without it.

Resolved stale release conflict: rebased feat/reviewed-mist-animations onto current origin/release, preserved current LiveBoardFx card-exit/stage-glow behavior, refreshed PR #396, and verified GitHub CI plus full local suite green.

Avi re-review APPROVED (Shannon primary + Alex light): merge-conflict block resolved — rebased 0-behind release (merge-base==release tip 10b87f79). deployments_broadcaster.rb byte-identical to release (Turbo Stream contract unchanged, acceptance #4). _board.html.erb resolved with a surgical useLiveExit guard gating BOTH the local pre-animate and the dropzone DOM move (won't fight the Turbo remove); release fallback intact, no lost hunk/markers, dual render paths coherent. CI green. Ready for Steffon's qa-release sweep.