McRitchie Studio
Say Hi 👋
Agents Builders
← All Tasks
Sizing

Rename review supervisor script

Archived
rename-review-supervisor-script

Created

Jul 04, 19:09

Started

Jul 04, 19:21

Completed

Jul 04, 21:06

DevOps handoff

Type

Chore

Shape

backend

Worktree Slug

rename-review-supervisor-script

Repositories

mcritchie-studio

Release Slug

—

Branch

feat/rename-review-supervisor-script

Pull Request

https://github.com/amcritchie/mcritchie-studio/pull/377

Local URL

—

QA URL

—

Production URL

—

devops

Acceptance Criteria

  • supervisor script named after the pr-review act
  • legacy avi-heartbeat name still works as shim
  • banner logs and output dir say pr-review
  • docs and tests reference the new script name
  • act SOPs drop upward heartbeat authority phrasing

Expected Test Plan

  • unit

Checks Run

  • [integration] bin/rails test test/commands/pr_review_command_test.rb — renamed supervisor exercised across its process boundary, banner + paths pinned
  • [unit] bin/rails test test/docs/ — invocation-standard pins updated to bin/pr-review, green
  • [full-suite@a3ea567d85ab804242eba4a82ab75ad8669f4820] bin/rails test green
  • [rubocop@a3ea567d85ab804242eba4a82ab75ad8669f4820] bin/rubocop clean

Agent Context

Scope from the 2026-07-04 heartbeat vocabulary audit (operator principle: heartbeats reference SOPs, never the other way around). (1) Rename bin/avi-heartbeat -> bin/pr-review (act name = script name = SOP name); keep bin/avi-heartbeat as a thin exec shim (legacy alias pattern like qa-deploy); rename tmp/avi-heartbeat output dir + banner 'Avi Heartbeat RUN' + 'Avi Heartbeat Retrospective' strings to pr-review vocabulary. Update references: docs/agents/claude.md, agents/avi/sops/pr-review.md + pr-review-slow.md, modules/heartbeats.md, modules/parallel-agent-devops.md, system/devops-cycle-design.md, test/commands/avi_heartbeat_command_test.rb (rename file too), test/docs/review_lane_docs_test.rb (pins claude.md phrase 'do not start with bin/avi-heartbeat --help' — update both sides together). (2) Reword the two upward SOP->heartbeat authority phrases: agents/avi/sops/production-deploy.md line ~16 'launched an Avi heartbeat with ship authority, or otherwise' -> drop the heartbeat clause, keep 'launched production-deploy or otherwise granted production ship authority in this session'; agents/alex/sops/full-cycle.md line ~17 same pattern for 'launched an Alex heartbeat with full release authority'. Matching table copy in modules/heartbeats.md stays (heartbeat->SOP direction is correct there). OUT OF SCOPE (audited, intentionally kept): /alex/heartbeat learning surface + HeartbeatController (distinct product concept, grade-events references it as a URL fact); bin/atomic-event heartbeat subcommand (launcher-layer attribution); bin/task heartbeat / statusline lease keep-alive (industry-standard keep-alive sense); devops-cycle-design section 4 'airgapped heartbeat agent' (future-architecture concept, design doc only). CAUTION: do not build while a pr-review wave is mid-flight — the supervisor writes logs under its own path.

Stage Timeline

Who handled each stage, the time it took (measured), and the model / tokens / cost reported (best-effort) — plus who's on it right now. — means the agent didn't report that metric.

Sizing Avi · PO SMALL Dev SMALL Actual XL ≠ forecast
  1. Created → Designed
    G Golem
    Golem
    Model
    —
    Duration
    —
    Tokens
    —
    Cost
    —
    Completed Jul 04, 19:09 · 4 days ago
    api
  2. Designed → Building
    G Golem
    Golem
    Model
    claude-fable-5
    Duration
    12 minutes
    Tokens
    6,150,309
    Cost
    ~$8.13
    Started Jul 04, 19:09
    Completed Jul 04, 19:21 · 4 days ago
    cli
  3. Building → Submitted
    G Golem
    Golem
    Model
    claude-fable-5
    Duration
    22 minutes
    Tokens
    22,766,897
    Cost
    ~$26.02
    Started Jul 04, 19:21
    Completed Jul 04, 19:43 · 4 days ago
    cli
  4. Submitted → Reviewed Review Activity
    C Carl
    Carl primary
    A Alex
    Alex light
    Model
    claude-fable-5
    Duration
    19 minutes
    Tokens
    —
    Cost
    —
    Started Jul 04, 19:43
    Completed Jul 04, 20:01 · 4 days ago
    cli
  5. Reviewed → Assembled
    S Steffon
    Steffon
    Model
    claude-fable-5
    Duration
    about 1 hour
    Tokens
    5,204,406
    Cost
    ~$6.90
    Started Jul 04, 20:01
    Completed Jul 04, 20:54 · 4 days ago
  6. Assembled → Shipped
    A Avi
    Avi
    Model
    claude-fable-5
    Duration
    12 minutes
    Tokens
    —
    Cost
    —
    Started Jul 04, 20:54
    Completed Jul 04, 21:06 · 4 days ago
  7. Shipped → Archived
    —
    Model
    —
    Duration
    about 5 hours
    Tokens
    —
    Cost
    —
    Started Jul 04, 21:06
    Completed Jul 05, 02:21 · 3 days ago

Conversation

QA review feedback, agent handoffs, and follow-up notes for this task.

Comment carl 4 days ago

Scout report: merge-ready - Primary review found no blockers: rename/shim/docs/tests meet acceptance, CI and local checks are green, and merge-tree overlap checks are clean. Reporter: carl Outcome: merge-ready Findings: - Blockers: none. - Acceptance covered: bin/pr-review is the primary supervisor, bin/avi-heartbeat execs it as a legacy shim, banners/retrospective/output_dir say pr-review, docs/tests use the new script name, and the two upward heartbeat authority clauses were removed. - Merge safety: PR #363 also touches docs/agents/modules/parallel-agent-devops.md and PR #361 touches docs/agents/system/devops-cycle-design.md, but both pairwise git merge-tree checks with PR #377 succeeded without conflicts. Questions: - none Checks: - Local: bin/rails test test/commands/pr_review_command_test.rb test/docs/review_lane_docs_test.rb => 13 runs, 188 assertions, green. - Local: bin/rails test test/docs/ => 13 runs, 154 assertions, green; bin/pr-review --help and bin/avi-heartbeat --help both show Usage: bin/pr-review. - GitHub PR #377 checks are green: scan_ruby, scan_js, lint, test; mergeStateStatus CLEAN.

Comment alex 4 days ago

Scout report: merge-ready - Light review finds no blockers; recommend merge-ready for PR #377. Reporter: alex Outcome: merge-ready Findings: - Acceptance criteria match: bin/pr-review is the supervisor, bin/avi-heartbeat execs it as a legacy shim, output uses pr-review/tmp/pr-review, docs/tests point to the new name, and act SOP authority wording is narrowed. - Merge safety is clean: PR targets release, GitHub reports mergeable, same-file open PRs merge cleanly by git merge-tree, and no dirty same-file worktree overlap was found. Questions: - none Checks: - GitHub CI for head 9e8ff5a passed scan_ruby, scan_js, lint, and test. - bin/rails test test/commands/pr_review_command_test.rb test/docs/review_lane_docs_test.rb passed: 13 runs, 188 assertions. - bin/pr-review and bin/avi-heartbeat dry-run with empty offline fixture both printed pr-review banner, tmp/pr-review output_dir, and pr-review Retrospective.

Handoff avi 4 days ago

Avi Heartbeat moved rename-review-supervisor-script to reviewed after carl + alex reported merge-ready. Left for Steffon QA. Reports: - carl: merge-ready - Primary review found no blockers: rename/shim/docs/tests meet acceptance, CI and local checks are green, and merge-tree overlap checks are clean. - alex: merge-ready - Light review finds no blockers; recommend merge-ready for PR #377.

Sealed-bid sizing

Edit →

Alex (PM)

—

Avi (PO)

SMALL

Dev

SMALL

Actual

XL