McRitchie Studio

PR #443 refines crew avatar hover so only the top stack avatar scales, documents 3/4-slot alignment, and has component/full-suite/RuboCop/manual smoke evidence recorded.

DoR-to-Merge is green for PR #443: component/manual/full-suite/rubocop evidence recorded and GitHub CI passed (lint, scan_js, scan_ruby, test).

Revision pushed to PR #443 at a801c88e: under-stack avatars and overlap stay fixed on hover; only the lead avatar scales, now to scale-125. DoR and GitHub CI are green.

Scout report: merge-ready - No code blockers in light UI read: lead avatar scales on its own wrapper, stack spacing stays fixed, and 3/4-slot alignment coverage matches acceptance. Current PR is clean against release with CI green at a801c88. Reporter: jasper Outcome: merge-ready Findings: - Blockers: none found. - Non-blocker merge safety: open PR #441 also edits app/views/components/_stage_agent_avatars.html.erb; git merge-tree reports a conflict if both branches merge without sequencing or rebase. - Non-blocker process: task-recorded full-suite/rubocop hash cbae5ad8eeb1598cf8eb5cba4e466c71fd7ebed1 is a tree/no GitHub commit, but GitHub CI test/lint are green on head a801c88. Questions: - none Checks: - Read AGENTS.md, pr-review-light SOP, README, frontend/deployment/testing docs, and Jasper role. - Inspected task metadata, PR body, changed files, diff, CI statusCheckRollup, and open-PR file overlap. - Compared origin/release...origin/pr-443; only avatar partial and component integration test changed, with no on-chain surface. - Did not rerun gates per light reviewer SOP.

Scout report: request-changes - Code meets the hover acceptance and gates are green, but the PR is not merge-ready because it conflicts with already-reviewed PR #441 and is still draft. Reporter: shannon Outcome: request-changes Findings: - Blocker: PR #441 (shiny-badge-polish) is already reviewed and git merge-tree reports a conflict in app/views/components/_stage_agent_avatars.html.erb around the avatar render line; rebase/reconcile #443 with #441 before advancing. - Blocker: gh pr view/pr-status show #443 is still draft=true; the release path should not carry it until owner intent is confirmed and the PR is marked ready. Questions: - none Checks: - PASS: bin/dor-check refine-crew-hover -> DoR met; component tier green; full suite + rubocop certified at cbae5ad8eeb1; GitHub CI green. - PASS: Ruby 3.3 PATH bin/rails test test/integration/board_card_stage_avatars_test.rb -> 15 runs, 96 assertions, 0 failures. - PASS: curl -I http://localhost:3021/deployments -> HTTP/1.1 200 OK; rendered markup has scale-125 only on data-stack-position=top and no stack hover spacing classes. - FAIL: git merge-tree origin/release HEAD feat/shiny-badge-polish -> changed in both app/views/components/_stage_agent_avatars.html.erb.

pr-review blocked review: shannon: request-changes - Code meets the hover acceptance and gates are green, but the PR is not merge-ready because it conflicts with already-reviewed PR #441 and is still draft.; jasper: merge-ready - No code blockers in light UI read: lead avatar scales on its own wrapper, stack spacing stays fixed, and 3/4-slot alignment coverage matches acceptance. Current PR is clean against release with CI green at a801c88.

Revision pushed to PR #443 at 8efe6327: lead avatars now scale to scale-150; first filled lead avatar nudges 4px left and last filled lead avatar nudges 4px right; under-stack avatars and stack spacing remain fixed. DoR and GitHub CI are green.

Revision pushed to PR #443 at e61531a8: first/last filled lead avatars now move 8px outward on hover while scale-150 and fixed under-stack behavior remain unchanged. DoR and GitHub CI are green.

Revision pushed to PR #443 at b7f6144f: latest release merged, conflict resolved with PR #441 shiny-badge behavior preserved, and edge lead avatars now nudge 12px outward. DoR and GitHub CI are green; PR is mergeable.

Resolved latest review feedback: merged origin/release into PR #443, preserved PR #441 shiny-badge behavior, resolved the avatar partial conflict, and GitHub now reports the PR mergeable with CI green.

Mr. McRitchie approved the visual behavior; prior conflict/draft feedback is resolved; PR #443 is ready, mergeable, CI-green, and DoR-green for Steffon's qa-release sweep.

Scout report: merge-ready - No code blockers; acceptance verified on b7f6144f, but PR #443 was merged to release and task advanced to assembled during this primary review. Reporter: shannon Outcome: merge-ready Findings: - Blockers: none. Non-blocker/process: bin/dor-check now refuses only because the PR is MERGED, not open; no same-file overlap found among open release PRs. Questions: - none Checks: - [ci] GitHub CI current head b7f6144f: scan_ruby, scan_js, lint, test all success; [component] Homebrew Ruby targeted tests: 20 runs, 132 assertions, 0 failures; [manual] localhost:3021/deployments 200 and Playwright hover probe top +16px, under +0px.