McRitchie Studio

Improved glow smoothness by changing the primitive to continuous forward motion and seeded each glowing task card with deterministic offset, duration, and angle variables. This breaks synchronized color bands between stacked cards without random refresh jumps. PR #415 updated; local preview http://localhost:3004/deployments; full-suite/rubocop fingerprint 6ded5a32265c; CI green.

Scout report: conductor-review - Randomized glow motion meets its UI acceptance, but shared PR #415 is draft and includes blocked sibling tasks, so Avi should reconcile PR readiness before review advances. Reporter: jasper Outcome: conductor-review Findings: - No code blockers for randomized motion: task cards derive deterministic per-card --studio-border-glow-offset, duration, and angle variables from task.slug, while CSS animates only background-position on absolute pseudo-elements. - Reduced motion remains covered at the primitive level by setting animation: none on .studio-border-glow::before and ::after; submitted cards also keep --studio-border-glow-animation: none. - Merge/admin gate: PR #415 isDraft=true and the same PR includes blocked sibling tasks deployment-rainbow-border, deployment-border-variants, and pokemon-assembled-glow, so this task should not be treated as independently merge-ready. - Merge safety otherwise looks clean: GitHub reports mergeStateStatus CLEAN, git merge-tree HEAD origin/release returned a clean tree, and other open release PRs do not touch this deployment-card CSS/partial/test file set. Questions: - none Checks: - [component] bin/rails test test/views/task_card_test.rb test/views/deployments_live_fx_test.rb passed: 19 runs, 273 assertions. - [integration] live smoke at http://localhost:3004/deployments found 5 task glow cards with varied offsets, durations, and angles; /up returned 200. - [dor] bin/dor-check randomized-glow-motion passed with component tier, full-suite/rubocop certificate, and 4 green GitHub CI checks. - [ci] gh pr checks 415 reports scan_ruby, scan_js, lint, and test all pass at PR head d2c0ccc.

Scout report: merge-ready - Primary UI review found the randomized deployment glow change merge-ready; seeded card motion, reduced-motion behavior, tests, CI, and merge safety all check out. Reporter: shannon Outcome: merge-ready Findings: - No blockers: deploy-lane cards get deterministic per-card offset/duration/angle variables and the shared border primitive keeps animation in pseudo-elements outside layout flow. - Non-blocker: PR #415 is still draft, but qa-release normalizes reviewed PRs with gh pr ready before carrying them. Questions: - none Checks: - [component] bin/rails test test/views/task_card_test.rb test/views/deployments_live_fx_test.rb green on PR worktree (19 runs, 273 assertions). - [integration] bin/rails test test/controllers/tasks_controller_test.rb -n '/deployments cards glow for deploy lane attention stages/' green on PR worktree (1 run, 39 assertions). - [dor] bin/dor-check randomized-glow-motion green on PR worktree; GitHub CI reports scan_ruby, scan_js, lint, and test successful. - [smoke] curl http://localhost:3004/deployments found 5 studio-border-glow cards with varied offsets/durations/angles, blocked_with_studio_glow=0, and compiled CSS reduced-motion animation:none. - [merge] git merge-tree --write-tree origin/release origin/feat/deployment-rainbow-border returned clean tree; open PR scan found no same-file overlap.

pr-review deferred randomized-glow-motion: conductor-review. shannon: merge-ready - Primary UI review found the randomized deployment glow change merge-ready; seeded card motion, reduced-motion behavior, tests, CI, and merge safety all check out.; jasper: conductor-review - Randomized glow motion meets its UI acceptance, but shared PR #415 is draft and includes blocked sibling tasks, so Avi should reconcile PR readiness before review advances.

Both reviewers (Shannon primary + Carl light) APPROVE the code and acceptance — re-certification, NOT code rework. bin/dor-check RED: [full-suite]/[rubocop] certs fingerprint-STALE (bound to 6ded5a32) vs PR head 95a41b10; final stack commits landed after the cert. GitHub CI fully green on head 95a41b10. Re-cert at head: bin/full-suite-check randomized-glow-motion then bin/dor-check randomized-glow-motion back-to-back, then resubmit. Optional polish while you re-touch (NON-blocking): the per-card uniqueness test asserts offsets.uniq==offsets on two random slugs (~0.25% seed%400 collision → occasional CI flake) — use fixed slugs or assert the offset+duration+angle tuple.

Resolved recert blocker: refreshed checks_run with current-head f887e67b full-suite/RuboCop cert and DoR is green.