McRitchie Studio

PR #440 opened against release with expected team totals cache, 272-game source CSV, post-deploy command bin/rails nfl:expected_team_totals_cache YEAR=2026, local cache verified at 544 projections. Full suite and rubocop green at d8eae10741c0; GitHub CI lint/test still running at handoff.

Scout report: request-changes - Light review found no derivation/cache code defect, but migration lane metadata is missing while the PR ships a Rails migration and schema change. Reporter: alex Outcome: request-changes Findings: - Blocker: task requires_migration=false and risk_tags omit migration even though PR adds db/migrate/20260707120000_create_nfl_team_total_projections.rb and modifies db/schema.rb; exclusive-lanes says migration/schema tasks must enter backend_migration. - Merge safety: PR #445 also edits db/schema.rb; git merge-tree shows a schema-version conflict if #445 and #440 are combined without rebasing/serializing. Questions: - Should Avi clear the draft state only after the migration flag/lane ordering is corrected? Checks: - Inspected AGENTS.md, PR light SOP, README, RUNBOOK, nfl-pipeline docs, task JSON, PR metadata/diff, CI rollup, CSV counts, qa-intake, and open PR file overlap. - CI rollup for 406aac6 is green: scan_ruby, scan_js, lint, and test all passed; I did not rerun gates.

Scout report: request-changes - Primary review found a data-cache blocker: strict imports can partially write projections before raising. Reporter: carl Outcome: request-changes Findings: - Blocker: Nfl::CacheExpectedTeamTotals writes projection rows before strict missing-game validation raises; app/services/nfl/cache_expected_team_totals.rb:47-69 leaves partial cache rows committed on a bad later CSV row. - Non-blocker: PR is still draft; qa-release can undraft when ready, but review verdict is blocked on code. Questions: - none Checks: - DoR passed; GitHub CI green; targeted Rails tests green; 2026 cache rake task wrote 544 projections; transaction probe showed rows_after_error=2.

pr-review blocked review: carl: request-changes - Primary review found a data-cache blocker: strict imports can partially write projections before raising.; alex: request-changes - Light review found no derivation/cache code defect, but migration lane metadata is missing while the PR ships a Rails migration and schema change.

Closing as superseded: the accepted implementation lives in Turf Monster PR #172, which merged the 2026 NFL expected team totals seed, cache, UI, Link Hub entry, and slate-board wiring in the owning app. Draft McRitchie Studio PR #440 was closed instead of reworked.