McRitchie Studio

Scout report: merge-ready - Light review found the production-deploy SOP guard order matches the task: it checks assembled state and qa_deployed_at before confirming/start or ship; CI is green and merge state is clean. Reporter: alex Outcome: merge-ready Findings: - No blockers. The PR is still marked draft on GitHub, but the submitted task, acceptance match, green CI, and clean merge state are otherwise ready for Avi/primary decision. Questions: - none Checks: - [static] Inspected PR diff for docs/agents/agents/avi/sops/production-deploy.md guard order. - [static] Compared SOP guard to Release states/stage stamps and task-board release timeline. - [unit] bin/rails test test/docs/ship_docs_sync_docs_test.rb with Ruby 3.3 PATH override (4 runs, 18 assertions). - [ci] gh pr checks 392: lint, scan_js, scan_ruby, test pass. - [merge] GitHub mergeStateStatus CLEAN; no other open PR touches production-deploy SOP.

Scout report: request-changes - Primary review: SOP guard order is conceptually right and CI/local checks are green, but the Heroku runner guard can fail open without --exit-code. Reporter: carl Outcome: request-changes Findings: - BLOCKER: docs/agents/agents/avi/sops/production-deploy.md:55 runs heroku run without --exit-code, while the SOP relies on the remote rails runner exit(1); bin/release.rb documents that without --exit-code heroku can return success once the dyno launches, so Avi could still stamp confirming with blank qa_deployed_at. - NON-BLOCKER: PR #392 is draft, but Steffon's qa-release SOP explicitly normalizes draft PRs with gh pr ready before the sweep; merge state is CLEAN and CI is green. Questions: - none Checks: - Read AGENTS.md, Avi pr-review SOP, shared PR review SOP, README, RUNBOOK, ECOSYSTEM, deployment/testing docs, production-deploy SOP, and relevant qa-release handoff docs. - Inspected task metadata, PR body/comments/reviews, changed files, diff, release model/ship path, docs tests, CI, and merge safety. - Local PR-head checks: bin/rails test test/docs/ship_docs_sync_docs_test.rb passed under the repo-documented Homebrew Ruby path (4 runs, 18 assertions); runner snippet ruby -c passed; bin/dor-check guard-avi-ship-gate passed. - GitHub checks on 42e3e86c all pass: scan_ruby, scan_js, lint, test; merge-tree against origin/release has no conflict.

pr-review blocked review: carl: request-changes - Primary review: SOP guard order is conceptually right and CI/local checks are green, but the Heroku runner guard can fail open without --exit-code.; alex: merge-ready - Light review found the production-deploy SOP guard order matches the task: it checks assembled state and qa_deployed_at before confirming/start or ship; CI is green and merge state is clean.

Addressed Carl blocker: documented Heroku guard now uses --exit-code so non-ready Release.current exits nonzero instead of failing open.

Scout report: merge-ready - Primary review: current head fixes the prior Heroku exit propagation blocker; production-deploy SOP now guards Release.current assembled + qa_deployed_at before confirming/start or ship, with checks/CI/merge safety green. Reporter: carl Outcome: merge-ready Findings: - No blockers: docs/agents/agents/avi/sops/production-deploy.md gates bin/release status, release state, and qa_deployed_at before confirming/start, and --exit-code propagates a non-ready runner exit. - Non-blocker: PR #392 is still draft on GitHub; it is submitted on the board, CLEAN/MERGEABLE, and CI green, so merge readiness depends only on normal conductor/QA undraft handling. - Merge safety: only production-deploy SOP changes; no other open PR touches that file. PR #395 touches adjacent agent docs but not this SOP. Questions: - none Checks: - Read /Users/alex/projects/AGENTS.md, README, RUNBOOK, Avi pr-review SOP, modular PR review SOP, production-deploy SOP, task-board release timeline docs, and relevant release code. - Inspected task metadata, PR body, changed file/diff, PR comments/reviews, GitHub merge state, CI, and worktree cleanliness. - [unit] mise exec ruby@3.3.11 -- bin/rails test test/docs/ship_docs_sync_docs_test.rb: 4 runs, 18 assertions, 0 failures. - [static] ruby -c production-deploy runner snippet: Syntax OK; rg -- '--exit-code' production-deploy SOP found the Heroku guard. - [dor] mise exec ruby@3.3.11 -- bin/dor-check guard-avi-ship-gate: DoR n/a for chore, ready submitted -> reviewed. - [ci] gh pr checks 392: lint, scan_js, scan_ruby, test pass; gh mergeStateStatus CLEAN/MERGEABLE.

Scout report: merge-ready - Light review: production-deploy SOP gates Avi confirming and ship behind assembled plus qa_deployed_at with Heroku --exit-code propagation; focused docs/static checks and CI are green. Reporter: alex Outcome: merge-ready Findings: - No blockers: guard is ordered before confirming/start and before bin/release ship; non-ready Release.current exits nonzero and SOP says not to stamp or ship. - Non-blocker merge-safety note: GitHub reports PR #392 as draft; Steffon's qa-release SOP normalizes carried PRs with gh pr ready before the sweep. - No overlap found: open-PR scan showed only #392 touches docs/agents/agents/avi/sops/production-deploy.md; origin/release is ancestor and PR is two commits ahead. Questions: - none Checks: - [static] inspected PR diff and production-deploy SOP guard order at origin/pr-392 - [unit] brew Ruby PATH bin/rails test test/docs/ship_docs_sync_docs_test.rb (4 runs, 18 assertions) - [static] ruby -c runner snippet; rg -- --exit-code docs/agents/agents/avi/sops/production-deploy.md; git diff --check origin/release...HEAD - [static] gh pr checks 392 green; bin/dor-check guard-avi-ship-gate

pr-review moved guard-avi-ship-gate to reviewed after carl + alex reported merge-ready. Left for Steffon QA. Reports: - carl: merge-ready - Primary review: current head fixes the prior Heroku exit propagation blocker; production-deploy SOP now guards Release.current assembled + qa_deployed_at before confirming/start or ship, with checks/CI/merge safety green. - alex: merge-ready - Light review: production-deploy SOP gates Avi confirming and ship behind assembled plus qa_deployed_at with Heroku --exit-code propagation; focused docs/static checks and CI are green.