McRitchie Studio

Scout report: merge-ready - Light review: CI gate implementation matches acceptance; live PR CI is green and dor-check is ready. Reporter: jasper Outcome: merge-ready Findings: - No blockers. Overlaps PR #361 in bin/dor-check, docs/agents/system/devops-cycle-design.md, and test/lib/dor_check_test.rb, but pairwise git merge-tree is clean and the combined tree preserves both gate changes. Questions: - none Checks: - ruby -Itest test/lib/ci_status_test.rb; ruby -Itest test/lib/dor_check_test.rb; bin/dor-check gate-dor-check-on-github-ci --json; gh pr checks 399; git merge-tree --write-tree --quiet origin/feat/harden-the-devops-gate origin/feat/gate-dor-check-on-github-ci

Scout report: request-changes - Blocker found: the CI gate checks statuses but does not verify that the PR is open, so a closed PR with green historical checks can pass as GitHub CI green. Reporter: carl Outcome: request-changes Findings: - BLOCKER: No-open-PR acceptance is not met. CiStatus only shells out to gh pr checks for a nonblank pr_url; gh pr checks returns green checks for closed PR #397, and PR #399 code reports ready/GitHub CI green instead of an unverifiable note. - NON-BLOCKER: PR #399 is open against release, mergeable/clean, and current GitHub CI is green on head 70ddc805. - NON-BLOCKER: Open PR #361 overlaps bin/dor-check, devops-cycle-design docs, and dor_check_test, but merge-tree auto-merges both orders; sequencing awareness only. Questions: - none Checks: - Read /Users/alex/projects/AGENTS.md, README.md, Avi pr-review SOP, pr-review module, testing docs, and DoR design docs. - Inspected task metadata, PR body, diff, changed files, and GitHub CI via gh pr view/checks. - Ran focused PR-head tests from archive: ruby -Itest test/lib/ci_status_test.rb passed 10/23; ruby -Itest test/lib/dor_check_test.rb passed 85/547. - Verified recorded full-suite/rubocop fingerprint 372c1618 matches origin/pr-399 tree and live dor-check CI probe reports GitHub CI green (4 checks). - Reproduced blocker with PR code: local task JSON using closed PR #397 returned DoR-to-Merge met and GitHub CI green.

pr-review blocked review: carl: request-changes - Blocker found: the CI gate checks statuses but does not verify that the PR is open, so a closed PR with green historical checks can pass as GitHub CI green.; jasper: merge-ready - Light review: CI gate implementation matches acceptance; live PR CI is green and dor-check is ready.

Resolved carl's request-changes (a closed/merged PR with green HISTORICAL checks passing as live 'CI green'). Fix (commit 8fb95a73): CiStatus.evaluate now reads 'gh pr view --json state' FIRST — a non-open PR is its own verdict (:closed/:merged) that the merge gate BLOCKS, never :green. 'gh pr checks' returns the head commit's historical checks even on a closed/merged PR, so a stale devops.pr_url no longer passes as green. Added closed/merged injection tokens + regression tests (unit maps the states; integration asserts the gate blocks a closed and a merged PR). Verified against the REAL gh path: merged PR #397 → :merged, open+green PR #399 → :green. Re-certified both lanes green at 5aeefabec18d (one pokemon_evolution_tree flake — unrelated parallel-run seed pollution — cleared on a clean re-run). dor-check ✓ (dogfooded: it read PR #399's real CI). jasper already marked merge-ready.

Scout report: merge-ready - Primary review: CI merge gate satisfies the task; PR #399 is open, green, clean against release, and ready for Avi/Steffon flow. Reporter: carl Outcome: merge-ready Findings: - Blockers: none. The red/pending/open-state CI gate is merge-gate-only, degrades gh/no-check errors to notes, and keeps deterministic DOR_CHECK_CI_STATUS coverage. - Non-blocker: open PR #361 overlaps bin/dor-check, test/lib/dor_check_test.rb, and devops-cycle-design.md; both sequential merge orders simulated clean. Questions: - none Checks: - [ci] gh pr view/checks #399: open, non-draft, mergeState CLEAN, scan_ruby/scan_js/lint/test all SUCCESS. - [unit+integration] PATH=/opt/homebrew/opt/ruby@3.3/bin:... bin/rails test test/lib/ci_status_test.rb test/lib/dor_check_test.rb: 97 runs, 582 assertions, 0 failures. - [gate] bin/dor-check gate-dor-check-on-github-ci --json: ready true, ci green (4 checks), full-suite/rubocop fingerprint fresh at 5aeefabec18d. - [merge-safety] Temporary release worktree merged #399 then #361 clean, and #361 then #399 clean.

Scout report: merge-ready - Light review found no blockers; PR #399 is open, clean against release, and dor-check now gates merge on real GitHub CI while leaving build gate untouched. Reporter: jasper Outcome: merge-ready Findings: - No blockers in the changed gate code: CiStatus feeds only the merge gate; red/pending/closed/merged states block, green passes, and gh/no-checks degrade to non-blocking suggestions. - Open PR #361 overlaps bin/dor-check, test/lib/dor_check_test.rb, and the DevOps design doc, but an isolated merge rehearsal of #399 then #361 auto-merged cleanly. - Non-blocking wording note: the task text says no-PR should be noted unverifiable, while this PR intentionally keeps a missing pr_url silent; no-checks and gh-error paths still show UNVERIFIED suggestions. Questions: - none Checks: - ruby -Itest test/lib/ci_status_test.rb: 10 runs, 25 assertions, green. - ruby -Itest test/lib/dor_check_test.rb: 87 runs, 557 assertions, green. - bin/dor-check gate-dor-check-on-github-ci: ready, full-suite fingerprint 5aeefabec18d, GitHub CI green (4 checks). - gh PR metadata: #399 is OPEN, base release, mergeState CLEAN, head 8fb95a73, four CI checks passing.

pr-review moved gate-dor-check-on-github-ci to reviewed after carl + jasper reported merge-ready. Left for Steffon QA. Reports: - carl: merge-ready - Primary review: CI merge gate satisfies the task; PR #399 is open, green, clean against release, and ready for Avi/Steffon flow. - jasper: merge-ready - Light review found no blockers; PR #399 is open, clean against release, and dor-check now gates merge on real GitHub CI while leaving build gate untouched.