McRitchie Studio

Scout report: request-changes - Light review found highlight selection ranks by size, not measured cost, so the release card can omit the true highest-cost tasks. Reporter: jasper Outcome: request-changes Findings: - Blocker: release_member_highlights sorts by release_member_expense_weight from size fields only; measured task.total_cost is used for badges but ignored for selection. Questions: - none Checks: - Read AGENTS, light SOP, Jasper role, README/data model/routes/deployment docs; inspected task metadata, PR body, diff/tests/CI, merge-tree; local /up 200 and deployments HTML shows condensed markup.

Scout report: request-changes - DoR, CI, focused tests, and Tailwind are green, but the highlight selection misses measured highest-cost tasks. Reporter: shannon Outcome: request-changes Findings: - Blocker: app/helpers/application_helper.rb release_member_highlights ranks only actual/dev/po size weight, so a high-dollar small task can be hidden behind unpriced XL/L tasks; violates 'two highest-cost tasks'. - Non-blocker: GitHub PR #444 is still draft even though the task is submitted. Questions: - none Checks: - bin/dor-check condense-release-tasks passed; GitHub CI lint/scan_js/scan_ruby/test all pass. - Homebrew Ruby PATH bin/rails test test/helpers/application_helper_test.rb test/controllers/tasks_controller_test.rb passed (146 runs, 1049 assertions). - bin/rails tailwindcss:build passed; http://localhost:3019/up returned 200 and /deployments rendered highlighted release member markup.

pr-review blocked review: shannon: request-changes - DoR, CI, focused tests, and Tailwind are green, but the highlight selection misses measured highest-cost tasks.; jasper: request-changes - Light review found highlight selection ranks by size, not measured cost, so the release card can omit the true highest-cost tasks.

Resolved QA blocker: release highlights now rank by measured total_cost before size fallback; focused tests, full suite, rubocop, GitHub CI, and dor-check are green.

Scout report: merge-ready - Light UI/release-dashboard read found no blockers; condensed current release members match acceptance and CI is green. Reporter: jasper Outcome: merge-ready Findings: - Blockers: none found in helper, partial, tests, PR body, task metadata, or rendered /deployments markup. - Non-blocker: PR is still draft and overlaps same files with open PRs #438 and #434; GitHub currently reports CLEAN against release. Questions: - none Checks: - Read AGENTS.md, README, ECOSYSTEM, Avi pr-review-light SOP, Jasper role checklist, task metadata, PR body, diff, and changed files. - Verified reported checks via gh pr checks: lint, scan_js, scan_ruby, and test all pass; did not rerun gates. - Local URL http://localhost:3019/deployments returned 200 with two highlighted task links, two cost badges, fade-mask title spans, and repo-count summaries.

Scout report: request-changes - Acceptance and test gates pass, but merge safety fails against submitted PR #438. Reporter: shannon Outcome: request-changes Findings: - Blocker: non-mutating git merge-tree of PR #444 with PR #438 reports a content conflict in test/helpers/application_helper_test.rb, so the release sweep can fail depending merge order. - Non-blocker: PR #444 is still marked draft on GitHub even though DOR and CI are green. Questions: - none Checks: - Read AGENTS.md, README, frontend/testing/routes/data-model docs, Avi primary SOP, PR body, task metadata, diff, and Shannon UI checklist. - bin/dor-check condense-release-tasks passed; GitHub CI scan_ruby, scan_js, lint, and test all pass at 8faf1a01. - Targeted Rails tests passed with brew Ruby PATH: 146 runs, 1049 assertions in test/helpers/application_helper_test.rb and test/controllers/tasks_controller_test.rb. - bin/rails tailwindcss:build and bin/rubocop passed with brew Ruby PATH; git diff --check clean. - http://localhost:3019/up and /deployments returned 200; rendered current release has 2 highlights, 2 cost badges, fade masks, and repo-count summaries.

pr-review blocked review: shannon: request-changes - Acceptance and test gates pass, but merge safety fails against submitted PR #438.; jasper: merge-ready - Light UI/release-dashboard read found no blockers; condensed current release members match acceptance and CI is green.

Resolved merge-safety blocker: rebased onto current origin/release, isolated release-member logic/tests into new files, and session-preflight now reports File overlap: none. Focused tests, full-suite cert, RuboCop, GitHub CI, and dor-check are green.

pr-review blocked review: primary found merge-safety conflict with PR #438 in test/helpers/application_helper_test.rb; acceptance and tests are otherwise green, but release sweep can fail depending merge order. Rebase or resolve against the reviewed/queued release work, then resubmit.

Resolved merge-safety blocker after owner send-it: rebased onto current origin/release, installed current agent docs, preflight reports File overlap: none, focused tests/full-suite/RuboCop/GitHub CI/dor-check are green.

Scout report: merge-ready - Light UI second read found the condensed current-release member summary aligned with acceptance; GitHub CI is green at PR head and merge/file-overlap safety is clean. Reporter: jasper Outcome: merge-ready Findings: - No blockers. - Non-blocker: task/PR local full-suite and RuboCop stamps reference cf5dadb1 rather than current head 21afea8b, but GitHub test/lint/scans succeeded at 21afea8b. Questions: - Only if product requires strict two-item condensation for every 3+ member release: this helper intentionally leaves three unsized/no-cost tasks visible as fixed highlight pills. Checks: - Read AGENTS, pr-review-light SOP, README, ecosystem/frontend/testing/deployment/data-model docs; inspected task metadata, PR body, final diff, helper/view/tests, CI, open PR file overlap, worktree status, and local /up.

Scout report: merge-ready - No blockers found. Current-release card condenses to two highlighted task links with fixed fade slots, cost badges, and repo-count remainder chips; DoR, CI, targeted Rails tests, and Tailwind build are green. Reporter: shannon Outcome: merge-ready Findings: - Acceptance match: local /deployments rendered 2 highlight links, 2 cost badges, fixed-width fade slots, and repo-count chips; highlighted links point to normal task URLs. - Merge safety: PR #444 is CLEAN/MERGEABLE against release, origin/release is an ancestor, and open PRs show no same-file overlap. - Non-blocker: if exactly three tasks have no measured cost or size, helper returns three highlights because there is no expense basis; consider tightening if product wants two slots unconditionally. Questions: - none Checks: - bin/dor-check condense-release-tasks passed; GitHub CI scan_ruby, scan_js, lint, test all pass at head 21afea8b. - Homebrew Ruby path bin/rails test for release_members_helper, application_helper, release_summary_members, and tasks_controller passed: 150 runs, 1057 assertions. - bin/rails tailwindcss:build passed; local http://localhost:3019/up returned 200; browser backend unavailable, so rendered HTML selectors were checked directly.

pr-review moved condense-release-tasks to reviewed after shannon + jasper reported merge-ready. Left for Steffon QA. Reports: - shannon: merge-ready - No blockers found. Current-release card condenses to two highlighted task links with fixed fade slots, cost badges, and repo-count remainder chips; DoR, CI, targeted Rails tests, and Tailwind build are green. - jasper: merge-ready - Light UI second read found the condensed current-release member summary aligned with acceptance; GitHub CI is green at PR head and merge/file-overlap safety is clean.