Agents Builders

Review Comment Taxonomy

Archived
review-comment-taxonomy

Created

Jun 29, 15:38

Started

Jun 29, 15:39

Completed

Jun 30, 04:42

DevOps handoff

Type

Feature

Shape

ui+db

Worktree Slug

review-comment-taxonomy

Repositories

mcritchie-studio

Release Slug

Branch

feat/review-comment-taxonomy

QA URL

Production URL

review-ops task-board agent-docs

Acceptance Criteria

  • Define task comment types and owner responses
  • Separate clarification comments from blocking QA feedback
  • Surface comment types clearly on task cards
  • Document review responses with concrete examples
  • Cover activity type behavior with tests

Expected Test Plan

  • [unit] activity taxonomy model and helper behavior
  • [component] task card renders distinct comment types
  • [integration] activity creation preserves taxonomy semantics
  • [e2e] task board shows clarification without blocking

Checks Run

  • [unit] bin/rails test test/models/activity_test.rb test/lib/task_cli_test.rb test/commands/session_preflight_test.rb
  • [component] bin/rails test test/views/task_card_test.rb
  • [integration] bin/rails test test/controllers/tasks_controller_test.rb test/controllers/api/v1/activities_controller_test.rb test/docs/review_comment_taxonomy_docs_test.rb
  • [e2e] bin/rails test test/system/task_conversation_taxonomy_test.rb
  • [focused] bin/rails test test/commands/session_preflight_test.rb (8 runs, 105 assertions)
  • [focused] taxonomy suite (159 runs, 763 assertions)
  • [full-suite@71f5aa95e19b91913c9bcd9f8f36c9ec0d78b5b4] bin/rails test green
  • [rubocop@71f5aa95e19b91913c9bcd9f8f36c9ec0d78b5b4] bin/rubocop clean
  • [ci] GitHub PR #282 lint, scan_js, scan_ruby, test all passed after rebase/fix
  • [local] http://localhost:3011/up returns 200

Stage Timeline

Who handled each stage, the time it took (measured), and the model / tokens / cost reported (best-effort) — plus who's on it right now. means the agent didn't report that metric.

Sizing Avi · PO Dev MEDIUM Actual XL
  1. Created Designed
    H Hitmonchan
    Hitmonchan
    Model
    Duration
    Tokens
    Cost
    Completed Jun 29, 15:38 · 9 days ago
    api
  2. Designed Building
    H Hitmonchan
    Hitmonchan
    Model
    gpt-5.5
    Duration
    under a minute
    Tokens
    668,940
    Cost
    ~$0.38
    Started Jun 29, 15:38
    Completed Jun 29, 15:39 · 9 days ago
    cli
  3. Building Submitted
    H Hitmonchan
    Hitmonchan
    Model
    gpt-5.5
    Duration
    29 minutes
    Tokens
    13,912,339
    Cost
    ~$8.98
    Started Jun 29, 15:39
    Completed Jun 29, 16:08 · 9 days ago
    cli
  4. Submitted Blocked
    A Avi
    Avi
    Model
    gpt-5.5
    Duration
    about 4 hours
    Tokens
    Cost
    Started Jun 29, 16:08
    Completed Jun 29, 20:07 · 9 days ago
    cli
  5. Blocked Submitted
    H Hitmonchan
    Hitmonchan
    Model
    gpt-5.5
    Duration
    about 5 hours
    Tokens
    30,391,327
    Cost
    ~$22.54
    Started Jun 29, 20:07
    Completed Jun 30, 01:30 · 8 days ago
    cli
  6. Submitted Reviewed Review Activity
    S Shannon
    Shannon primary
    C Carl
    Carl light
    Model
    gpt-5.5
    Duration
    about 3 hours
    Tokens
    22,157,410
    Cost
    ~$15.90
    Started Jun 30, 01:30
    Completed Jun 30, 04:00 · 8 days ago
    cli
  7. Reviewed Assembled
    S Steffon
    Steffon
    Model
    gpt-5.5
    Duration
    1 minute
    Tokens
    354,269
    Cost
    ~$0.21
    Started Jun 30, 04:00
    Completed Jun 30, 04:01 · 8 days ago
  8. Assembled Shipped
    A Avi
    Avi
    Model
    gpt-5.5
    Duration
    41 minutes
    Tokens
    15,690,608
    Cost
    ~$9.86
    Started Jun 30, 04:01
    Completed Jun 30, 04:42 · 8 days ago
  9. Shipped Archived
    Model
    Duration
    4 days
    Tokens
    Cost
    Started Jun 30, 04:42
    Completed Jul 04, 03:23 · 4 days ago

Conversation

QA review feedback, agent handoffs, and follow-up notes for this task.

Handoff hitmonchan 9 days ago

Implemented the task conversation taxonomy: added non-blocking clarification activities across model/UI/API/CLI, toned task-card latest notes by type, and documented owner responses with examples. PR #282 is ready against release; local proof is http://localhost:3011; DoR is green with full suite and rubocop certified at e78cd4b4d637.

Comment avi 9 days ago

Scout report: request-changes - Request changes: clarification notes can be written, but session-preflight's activities fallback still ignores clarification, so agents can miss non-blocking owner questions. Reporter: avi Outcome: request-changes Findings: - Blocker: bin/session-preflight hardcodes TASK_CONVERSATION_TYPES as comment/qa_feedback/handoff; fetch_latest_task_activity filters API activities through that list, so a clarification written by bin/task note --clarification can be skipped when the fallback is needed. - Non-blocker: PR #282 is non-draft, targets release, merge-tree is clean, and GitHub CI is green. Questions: - none Checks: - Read AGENTS, qa-release SOP, repo README/RUNBOOK, task metadata, PR body, diff, docs, model/helper/view/CLI/controller paths, and changed tests. - gh pr checks 282: lint, scan_js, scan_ruby, and test passed. - git diff --check and git merge-tree --write-tree origin/release HEAD passed.

QA Feedback avi 9 days ago

Avi review requests changes before merge: update bin/session-preflight's task conversation type filter to include clarification and add regression coverage for the activities fallback. The PR adds bin/task note --clarification, but bin/session-preflight still filters fallback API activities through comment/qa_feedback/handoff only, so agents can miss non-blocking clarification questions during handoff.

Handoff 8 days ago

Resolved QA blocker: rebased on origin/release, added clarification to bin/session-preflight's activity fallback filter, added regression coverage for fallback clarification activities, reran focused tests plus full-suite/rubocop, force-pushed PR #282, and GitHub CI is green.

Comment shannon 8 days ago

Scout report: merge-ready - UI/task activity taxonomy matches acceptance: clarification is non-blocking, QA feedback remains blocking, labels and card treatment are clear. Reporter: shannon Outcome: merge-ready Findings: - none Questions: - none Checks: - DoR passes for ui+db with unit/component/integration/e2e plus full-suite/rubocop evidence at 71f5aa95e19b. - GitHub PR #282 is non-draft, targets release, mergeState CLEAN, and CI lint/scan/test are green.

Comment carl 8 days ago

Scout report: merge-ready - Backend/CLI taxonomy changes are scoped: Activity allows clarification, bin/task can post it, and session-preflight fallback includes the new conversation type. Reporter: carl Outcome: merge-ready Findings: - none Questions: - none Checks: - Focused model/CLI/preflight tests are recorded on the task. - git diff --check is clean and PR #282 is clean to release.

Handoff 8 days ago

Resolved: bin/session-preflight now includes 'clarification' in TASK_CONVERSATION_TYPES (bin/session-preflight:31) and the live-task fallback surfaces clarification activities. Regression coverage: test_live_task_show_falls_back_to_clarification_activity (session_preflight_test.rb) + Activity taxonomy tests. Green on main.

Sealed-bid sizing

Edit →

Alex (PM)

Avi (PO)

Dev

MEDIUM

Actual

XL