McRitchie Studio

Scout report: request-changes - Boundary close path skips the live activity update broadcast. Reporter: carl Outcome: request-changes Findings: - Blocker: bin/agent-activity next sends prior_outcome through the create endpoint, but AgentActivity.open_activity! closes the previous row with update_all, bypassing the after_update_commit broadcaster; the previous activity can stay open on the live feed and never flash. Questions: - The page subscribes to a global agents_activities stream even when session filters are active; confirm additive out-of-filter inserts are acceptable or scope/drop them client-side. Checks: - Read AGENTS.md, Avi pr-review SOP, shared pr-review SOP, README, RUNBOOK, ECOSYSTEM, and relevant frontend/testing/routes/data-model docs. - Inspected PR #412 body, diff, changed files, tests, and task metadata; acceptance explicitly requires activity updates to replace rows live and flash. - GitHub reports PR #412 merged to release at 85c8c50 with scan_ruby, scan_js, lint, and test all passing. - Merge safety: changed files are activity-feed/broadcaster/test scoped, and open release PRs #379, #363, and #361 do not overlap these files.

Scout report: merge-ready - Light UI review: live Turbo stream path matches the acceptance criteria; no blocking defects found. PR #412 was already merged and the task assembled before this scout report. Reporter: shannon Outcome: merge-ready Findings: - No blocking UI defects found in the activity/action create-update stream path. - Non-blocker follow-up: the global agents_activities stream can insert new activities into filtered or older pages because the activity insert target is page-global; acceptable for this additive scope, but revisit if filtered live views must stay strict. - Process note: DoR now refuses the PR only because #412 is already merged; the recorded full-suite/rubocop fingerprint matches the PR head tree. Questions: - none Checks: - Read AGENTS.md, Avi pr-review SOP, shared PR-review module, README, ECOSYSTEM, frontend/testing/routes docs, and Shannon role/soul. - Reviewed task metadata, PR body, diff, changed files, CI, DoR state, and open-PR overlap; no same-file merge conflict risk found. - Focused Rails check passed: bin/rails test test/services/activities_broadcaster_test.rb test/integration/agents_activities_test.rb (22 runs, 98 assertions). - Local URL http://localhost:3014/agents/activities returned 200 and rendered the Turbo subscription plus stable activity/action DOM ids.

Avi pr-review verdicts landed after operator merge (PR #412 merged to release by amcritchie 02:08:45Z, task assembled mid-wave). Primary carl: request-changes — open_activity! update_all bypasses after_update_commit broadcaster, prior row never updates live. Light shannon: merge-ready, no blockers. Not dragging assembled work back; defect filed as follow-up bug task fix-boundary-close-broadcast (https://mcritchie.studio/tasks/fix-boundary-close-broadcast). Rides current release as-is.