Agents Builders

Keep mascot off deploy cards

Archived
keep-mascot-off-deploy-cards

Created

Jul 06, 04:50

Started

Jul 06, 04:51

Completed

Jul 06, 08:16

DevOps handoff

Type

Feature

Shape

ui-only

Worktree Slug

keep-mascot-off-deploy-cards

Repositories

mcritchie-studio

Release Slug

Branch

feat/keep-mascot-off-deploy-cards

QA URL

Production URL

ui timeline

Acceptance Criteria

  • Mascot renders only on Build lane cards
  • Assembled and Shipped cards show deploy soul alone
  • Evolve reel still reveals the final evolved form

Expected Test Plan

  • [unit] stage_agent_groups: assembled/shipped carry no MascotAgent
  • [component] consolidated timeline deploy cards omit mascot companion

Checks Run

  • [unit] bin/rails test test/helpers/stage_agents_helper_test.rb
  • [component] bin/rails test test/views/consolidated_timeline_test.rb
  • [full-suite@d3be91bb6ec196610cc91c5b560f43064e99b423] bin/rake test test:system green
  • [rubocop@d3be91bb6ec196610cc91c5b560f43064e99b423] bin/rubocop clean

Agent Context

Operator decision (option 1): the Pokemon mascot is the Build lane's face and the Evolve reel's star; it must NOT ride the Deploy cards. Today deploy_mascot_companion adds the mascot alongside Steffon (Reviewed->Assembled) and Avi (Assembled->Shipped) whenever no final-evolution reel claimed it — so a non-evolving mascot (e.g. Lugia) shows up twice. Remove the companion mechanism in app/helpers/stage_agents_helper.rb: drop MASCOT_COMPANION_STAGES + deploy_mascot_companion, the two companion appends in event_stage_agents, and the now-dead assembled/shipped MascotAgent-reject loops in apply_final_evolution!/insert_evolution_card! (keep the build-crew reveal + the Evolve reel). Both the board card and the /tasks/:id timeline go through event_stage_agents so both surfaces fix together.

Stage Timeline

Who handled each stage, the time it took (measured), and the model / tokens / cost reported (best-effort) — plus who's on it right now. means the agent didn't report that metric.

Sizing Avi · PO SMALL Dev SMALL Actual XL ≠ forecast
  1. Created Designed
    P Pidgey
    Pidgey
    Model
    Duration
    Tokens
    Cost
    Completed Jul 06, 04:50 · 2 days ago
    api
  2. Designed Building
    P Pidgey
    Pidgey
    Model
    claude-opus-4-8
    Duration
    under a minute
    Tokens
    1,107,653
    Cost
    ~$0.67
    Started Jul 06, 04:50
    Completed Jul 06, 04:51 · 2 days ago
    cli
  3. Building Submitted
    P Pidgeotto
    Pidgeotto
    Model
    claude-opus-4-8
    Duration
    17 minutes
    Tokens
    18,590,521
    Cost
    ~$12.44
    Started Jul 06, 04:51
    Completed Jul 06, 05:08 · 2 days ago
    cli
  4. Submitted Blocked
    A Avi
    Avi
    Model
    claude-opus-4-8
    Duration
    37 minutes
    Tokens
    Cost
    Started Jul 06, 05:08
    Completed Jul 06, 05:45 · 2 days ago
    cli
  5. Blocked Submitted
    P Pidgeotto
    Pidgeotto
    Model
    claude-opus-4-8
    Duration
    32 minutes
    Tokens
    8,211,072
    Cost
    ~$5.48
    Started Jul 06, 05:45
    Completed Jul 06, 06:17 · 2 days ago
    cli
  6. Submitted Reviewed Review Activity
    S Shannon
    Shannon primary
    J Jasper
    Jasper light
    Model
    claude-opus-4-8
    Duration
    about 2 hours
    Tokens
    Cost
    Started Jul 06, 06:17
    Completed Jul 06, 07:57 · 2 days ago
    cli
  7. Evolve
    P Pidgeotto
    Pidgeotto
    P Pidgeot
    Pidgeot
    triggered by
    S Shannon
    Shannon
    Model
    Duration
    about 2 hours
    Tokens
    Cost
    Started Jul 06, 06:17
    Completed Jul 06, 07:57 · 2 days ago
  8. Reviewed Assembled
    S Steffon
    Steffon
    Model
    claude-opus-4-8
    Duration
    10 minutes
    Tokens
    8,068,642
    Cost
    ~$4.39
    Started Jul 06, 07:57
    Completed Jul 06, 08:07 · 2 days ago
  9. Assembled Shipped
    A Avi
    Avi
    Model
    claude-opus-4-8
    Duration
    10 minutes
    Tokens
    3,745,181
    Cost
    ~$1.95
    Started Jul 06, 08:07
    Completed Jul 06, 08:16 · 2 days ago
  10. Shipped Archived
    Model
    Duration
    about 14 hours
    Tokens
    Cost
    Started Jul 06, 08:16
    Completed Jul 06, 22:06 · 1 day ago

Conversation

QA review feedback, agent handoffs, and follow-up notes for this task.

QA Feedback avi 2 days ago

Both reviewers (Shannon primary + Jasper light) APPROVE the code — this is a re-certification, NOT code rework. bin/dor-check is RED: the [full-suite]/[rubocop] certs are fingerprint-bound to tree bce53762, but the PR head is 92562a57 after #413/#414 merged into release beneath this PR (pure rebase artifact — the +74/-46 helper diff is byte-identical and GitHub CI is green on the head). No code change needed. Re-bind the cert to the current head in ONE shot: run bin/full-suite-check keep-mascot-off-deploy-cards then bin/dor-check keep-mascot-off-deploy-cards back-to-back (same root, so the cert is not stale between them), then move submitted and resubmit.

Handoff 2 days ago

Re-cert done per your diagnosis — no code change. Rebased feat/keep-mascot-off-deploy-cards onto current origin/release (absorbed #413/#414, no overlap with the helper diff), force-pushed → head 802fdbc9. Re-bound the cert to the new tree: bin/full-suite-check + bin/dor-check back-to-back, both lanes green at d3be91bb (bin/rake test test:system + rubocop). dor-check now PASS; GitHub CI green (4 checks). Ready for re-review.

Handoff shannon 2 days ago

Shannon UI review approved: companion removed cleanly at the single source (event_stage_agents) so both the board card and /tasks/:id timeline fix together; deploy tail returns actor/owner alone (never blank via STAGE_OWNER), no dangling refs to the dropped MASCOT_COMPANION_STAGES/deploy_mascot_companion, and a non-evolving-mascot regression is guarded at unit + component tiers. Build reveal + Evolve reel intact; CI green.

Sealed-bid sizing

Edit →

Alex (PM)

Avi (PO)

SMALL

Dev

SMALL

Actual

XL