McRitchie Studio

Scout report: merge-ready - Light review found the refined deployment rainbow border meets the UI acceptance criteria; CI and DoR are green, with the PR draft flag noted as administrative follow-up. Reporter: carl Outcome: merge-ready Findings: - Non-blocker: PR #415 is still marked draft even though mergeState is CLEAN and DoR reports ready; Avi or the primary reviewer should ensure it is marked ready before the merge sweep. Questions: - none Checks: - Read AGENTS, Avi pr-review SOP, README/RUNBOOK/deployment/frontend/testing/theme docs; inspected PR body/diff/CI; ran component tests, DoR, local deployments smoke, and desktop/mobile/reduced-motion Playwright probes.

Scout report: request-changes - Request changes: remote UI diff passes, but the local worktree is dirty and PR remains draft. Reporter: shannon Outcome: request-changes Findings: - Blocker: qa-intake marks PR #415 needs-agent because the deployment-rainbow-border worktree has uncommitted changes in app/assets/tailwind/application.css and test/views/task_card_test.rb, the same files this PR would merge. - Blocker: PR #415 is still draft; Steffon's qa-release SOP normalizes draft PRs with gh pr ready before the sweep can carry them. - Non-blocker: GitHub CI is green on PR head 577e90bd and mergeStateStatus is CLEAN; remote diff itself meets the rainbow border and reduced-motion acceptance. - Non-blocker: task checks_run names full-suite/rubocop at e14eb8c3, which is a tree object locally rather than the PR head commit; GitHub CI covers the actual head, but the handoff evidence should be cleaned up with the dirty worktree. Questions: - none Checks: - Read AGENTS.md, Avi pr-review SOP, pr-review primitive, README, RUNBOOK, deployment/theme/testing docs, and Steffon qa-release draft normalization note. - Inspected task metadata, PR body, remote diff, changed files, GitHub CI, merge-tree against origin/release, and open PR same-file overlap. - Ran focused local checks under Ruby 3.3: task card/live FX view tests passed; filtered deployments controller glow tests passed; bin/rails tailwindcss:build passed; curl http://localhost:3004/deployments returned 200. - Ran Playwright viewport/reduced-motion probes on localhost:3004; animated border computed normally and changed to animation none with reduced motion; desktop/tablet/mobile page overflow was 0.

pr-review blocked review: shannon: request-changes - Request changes: remote UI diff passes, but the local worktree is dirty and PR remains draft.; carl: merge-ready - Light review found the refined deployment rainbow border meets the UI acceptance criteria; CI and DoR are green, with the PR draft flag noted as administrative follow-up.

Resolved blocked review concerns: PR #415 is no longer draft, branch is pushed clean at 95a41b10, and DoR plus GitHub CI are green.

Avi review approved (Shannon primary + Alex light); PR #415 glow bundle ready for Steffon's qa-release sweep. Non-blocking follow-up for a future pass: add a one-block CSS contract comment above .studio-border-glow listing its 8 --studio-border-glow-* knobs; .task-card-stage-glow re-declares primitive defaults its -kind variants override (vestigial, safe to prune later). Neither affects acceptance.

Both reviewers (Shannon primary + Carl light) APPROVE the code and all five member-tasks' acceptance criteria — this is a re-certification, NOT code rework. bin/dor-check is RED for all 5 PR-415 members: the [full-suite]/[rubocop] certs are fingerprint-STALE (this member bound to f887e67b) vs PR head 95a41b10, because the final two stack commits landed after the certs. GitHub CI is fully green on head 95a41b10 (test/lint/scan_js/scan_ruby). No code change needed. Re-cert the branch at head in one shot: run bin/full-suite-check deployment-rainbow-border then bin/dor-check deployment-rainbow-border back-to-back (same root, so not stale between them) for each of the 5 members, then resubmit.

Resolved recert blocker: current PR #415 head 95a41b10 has fresh full-suite/RuboCop cert f887e67b and DoR is green.

Shannon UI review approved for the 5-task #415 bundle: clean refactor to a reusable .studio-border-glow primitive (::before ring + ::after halo, all CSS-var driven) with per-card seeded motion offsets, mascot-typed assembled colors, and fixed yellow/blue + green stage variants. All 5 acceptances met, reduced-motion fully disables animation, blocked cards correctly opt out, no rgba/var or ERB-comment gotchas, no dangling refs (LiveBoardFx keys off data-* not classes), CI green.