McRitchie Studio

Local validation ready. Added approval_status=waiting, pulsing board cards, Local Demo button, CLI support, and SOP/chat URL standards. Local Demo: http://localhost:3001/tasks. Checks are recorded in devops.checks_run.

Caveat: production currently drops devops.approval_status until this branch ships, because the live normalizer does not know the new key. The worktree Local Demo at http://localhost:3001/tasks includes approval-waiting-demo to show the pulsing waiting card and Local Demo button.

PR opened for Avi review: https://github.com/amcritchie/mcritchie-studio/pull/447. Task: https://mcritchie.studio/tasks/approval-ready-tasks. Local Demo: http://localhost:3001/tasks. Branch: feat/approval-ready-tasks. DoR passed; full suite and RuboCop certified at 4e77a838e109.

Scout report: conductor-review - Code and local behavior read clean; PR is still draft, so Avi should resolve the readiness mismatch before final gate. Reporter: carl Outcome: conductor-review Findings: - Question: GitHub reports PR #447 isDraft=true while task is submitted; CI is green and mergeStateStatus is CLEAN. - Non-blocker: open PR overlap exists in docs (#363) and Tailwind CSS (#438), but #447 is currently one commit ahead of release, behind_by 0, and mergeable clean. Questions: - none Checks: - Reviewed required docs/SOP/Carl role, task metadata, PR body/diff/files, GitHub checks, local /tasks HTML, and open-PR overlap; did not run gates.

Scout report: merge-ready - Primary review found no blockers; approval waiting state, ordering, pulse, Local Demo action, and handoff docs match acceptance with green gates. Reporter: shannon Outcome: merge-ready Findings: - No blockers: CLI approval status writes through devops metadata, Task stamps the first waiting request, board ordering floats waiting cards above stage peers, and the card renders the approval badge/glow plus Local Demo link. - Non-blocker: GitHub PR #447 is still draft even though DoR, CI, cert evidence, and focused checks are green; Avi/owner should mark ready before the release sweep can merge it. - Merge safety: PR is clean against origin/release; same-file overlap with #363 auto-merges, and #438's conflicts are pre-existing against release rather than introduced by this PR. Questions: - none Checks: - bin/dor-check approval-ready-tasks passed: required ui+db tiers, full-suite/rubocop cert at 4e77a838e109, and 4 GitHub CI checks green. - Reran focused Rails tests with Homebrew Ruby PATH: 214 runs, 821 assertions, 0 failures. - Reran PLAYWRIGHT_BASE_URL=http://localhost:3001 npx playwright test e2e/task_board_order.spec.js with Homebrew Ruby PATH: 2 passed; local /up and /tasks returned 200.

pr-review deferred approval-ready-tasks: conductor-review. shannon: merge-ready - Primary review found no blockers; approval waiting state, ordering, pulse, Local Demo action, and handoff docs match acceptance with green gates.; carl: conductor-review - Code and local behavior read clean; PR is still draft, so Avi should resolve the readiness mismatch before final gate.

Scout report: merge-ready - Light backend review found no blockers; approval wait metadata, ordering, pulse, Local Demo action, and handoff docs match acceptance. Reporter: carl Outcome: merge-ready Findings: - No blockers. Same-file overlap with #438 CSS and #363 docs appears to be non-overlapping drift; PR #447 is mergeable against release. Questions: - none Checks: - Read AGENTS, README, Carl role, pr-review-light SOP, and task-board docs; inspected task JSON, PR body, changed files, diff, tests, CI, local /tasks 200, and open PR overlap; did not rerun gates.

Scout report: request-changes - Request changes: one reduced-motion UI blocker; approval waiting behavior otherwise matches acceptance and gates are green. Reporter: shannon Outcome: request-changes Findings: - Blocker: app/views/tasks/_task_card.html.erb adds animate-pulse to the WAITING APPROVAL badge, but app/assets/tailwind/application.css only disables the card approval animation under prefers-reduced-motion; reduced-motion users still get the badge pulse. Use a motion-safe class or reduced-motion override and update the component assertion. Questions: - none Checks: - bin/dor-check approval-ready-tasks PASS; focused Rails approval tests PASS; Playwright task_board_order PASS; bin/full-suite-check --print PASS at 66e9a8550fd9; GitHub CI green; PR #447 mergeable/clean.

pr-review blocked review: shannon: request-changes - Request changes: one reduced-motion UI blocker; approval waiting behavior otherwise matches acceptance and gates are green.; carl: merge-ready - Light backend review found no blockers; approval wait metadata, ordering, pulse, Local Demo action, and handoff docs match acceptance.

Resolved review blocker: WAITING APPROVAL badge now uses motion-safe:animate-pulse, with component coverage confirming the raw animate-pulse class is absent. Rechecked focused Rails, Playwright board order, full suite, RuboCop, and DoR at 34473fe99e99.

Scout report: merge-ready - Carl light review found no blockers; approval wait state, board ranking, Local Demo action, and handoff docs align with acceptance. Reporter: carl Outcome: merge-ready Findings: - No blockers. Backend pass verified devops approval metadata is accepted by the API/CLI, waiting tasks sort ahead of stage peers, and the card pulse/button resolve when approval_status leaves waiting. Non-blocking merge-safety note: older open PR #363 also edits two docs modules, but PR #447 is clean against release. Questions: - none Checks: - Reviewed task metadata, PR body, changed files, docs, tests, GitHub checks, and merge safety; did not rerun gates per light SOP.

Scout report: merge-ready - No blockers found; approval wait metadata, sorting, pulse, Local Demo action, and handoff docs match acceptance. Reporter: shannon Outcome: merge-ready Findings: - Non-blocking: the reported PLAYWRIGHT_BASE_URL variable is not read by playwright.config.js; reran task-board e2e with CI=1 E2E_PORT=3059 against a fresh test server. Questions: - none Checks: - dor-check passed; CI green; full-suite-check --print passed full Rails suite and rubocop at 34473fe99e99; task-board Playwright spec passed 2/2.

pr-review moved approval-ready-tasks to reviewed after shannon + carl reported merge-ready. Left for Steffon QA. Reports: - shannon: merge-ready - No blockers found; approval wait metadata, sorting, pulse, Local Demo action, and handoff docs match acceptance. - carl: merge-ready - Carl light review found no blockers; approval wait state, board ranking, Local Demo action, and handoff docs align with acceptance.