McRitchie Studio
Say Hi 👋
Agents Builders
← All Tasks
Sizing

Fix Live-on-QA stamp timing

Archived
fix-live-on-qa-stamp-timing

Created

Jul 05, 22:33

Started

Jul 05, 22:34

Completed

Jul 06, 00:49

DevOps handoff

Type

Bug

Shape

backend

Worktree Slug

fix-live-on-qa-stamp-timing

Repositories

mcritchie-studio

Release Slug

—

Branch

feat/fix-live-on-qa-stamp-timing

Pull Request

https://github.com/amcritchie/mcritchie-studio/pull/406

Local URL

—

QA URL

—

Production URL

—

release-pipeline deploy-tracker

Acceptance Criteria

  • Live on QA green only after member flip
  • deploy_qa completed stamped inside qa_green atomically
  • not-green run leaves tracker at Deploying QA
  • regression test covers the stamp ordering

Expected Test Plan

  • unit
  • integration

Checks Run

  • [unit] qa_green! stamps deploy_qa:completed atomic with member flip; record_qa_url is URL-only; qa_url fallback
  • [integration] qa_green_stamp_ordering: tracker stays below Live-on-QA until members flip; not-green run stays dark
  • [unit] release_cli prepare sweep still fires qa_green! + assembles (184 CLI/model runs green)
  • [full-suite@72673e5450fe139afd707e8bdad8c976e3d634d5] bin/rails test green
  • [rubocop@72673e5450fe139afd707e8bdad8c976e3d634d5] bin/rubocop clean

Agent Context

bin/release prepare (release.rb) stamps deploy_qa:completed via record_qa_deploy at step 7 (line ~1339), BEFORE run_post_deploy (8a) and the reviewed->assembled member flip in qa_green! (8b, line ~1373). The /deployments tracker is monotonic (release.rb:24-30), so qa_deployed lights Tested/Assembled/Live-on-QA green at step 7 while member tasks are still reviewed and post-deploy hooks haven't run. If a post_deploy hook or qa_green! fails in the gap, the tracker shows a fully-green Live-on-QA with members stuck reviewed. Fix: make the deploy_qa:completed stamp atomic with the flip — fold it into Release::Conductor.qa_green!(release, qa_url:) (which already flips members + assemble!s the RC in one txn), and have bin/release step 7 record only qa_url + qa_shas (no stage-advancing event). Result: Live on QA green == members assembled + booted green. Not-green path stops the tracker at Deploying QA (qa_deploying). Verified 2026-07-05: rel-20260705-8fe04b eventually flipped fine; this closes the misleading window.

Stage Timeline

Who handled each stage, the time it took (measured), and the model / tokens / cost reported (best-effort) — plus who's on it right now. — means the agent didn't report that metric.

Sizing Avi · PO SMALL Dev SMALL Actual XL ≠ forecast
  1. Created → Designed
    T Togepi
    Togepi
    Model
    —
    Duration
    —
    Tokens
    —
    Cost
    —
    Completed Jul 05, 22:33 · 3 days ago
    api
  2. Designed → Building
    T Togepi
    Togepi
    Model
    claude-opus-4-8
    Duration
    under a minute
    Tokens
    1,094,357
    Cost
    ~$0.85
    Started Jul 05, 22:33
    Completed Jul 05, 22:34 · 3 days ago
    cli
  3. Building → Submitted
    T Togepi
    Togepi
    Model
    claude-opus-4-8
    Duration
    24 minutes
    Tokens
    33,605,591
    Cost
    ~$24.37
    Started Jul 05, 22:34
    Completed Jul 05, 22:58 · 3 days ago
    cli
  4. Submitted → Reviewed Review Activity
    C Carl
    Carl primary
    A Alex
    Alex light
    Model
    claude-opus-4-8
    Duration
    about 1 hour
    Tokens
    1,747,287
    Cost
    ~$3.20
    Started Jul 05, 22:58
    Completed Jul 06, 00:20 · 3 days ago
    cli
  5. Evolve
    T Togepi
    Togepi
    T Togetic
    Togetic
    triggered by
    C Carl
    Carl
    Model
    —
    Duration
    about 1 hour
    Tokens
    —
    Cost
    —
    Started Jul 05, 22:58
    Completed Jul 06, 00:20 · 3 days ago
  6. Reviewed → Assembled
    S Steffon
    Steffon
    Model
    claude-opus-4-8
    Duration
    14 minutes
    Tokens
    3,018,037
    Cost
    ~$3.15
    Started Jul 06, 00:20
    Completed Jul 06, 00:34 · 2 days ago
  7. Assembled → Shipped
    A Avi
    Avi
    Model
    claude-opus-4-8
    Duration
    15 minutes
    Tokens
    5,605,411
    Cost
    ~$5.04
    Started Jul 06, 00:34
    Completed Jul 06, 00:49 · 2 days ago
  8. Shipped → Archived
    —
    Model
    —
    Duration
    about 15 hours
    Tokens
    —
    Cost
    —
    Started Jul 06, 00:49
    Completed Jul 06, 15:43 · 2 days ago

Conversation

QA review feedback, agent handoffs, and follow-up notes for this task.

Handoff carl 3 days ago

Avi review APPROVED (carl primary + alex light). Stamp folded into qa_green!'s Release.transaction — atomic with the reviewed→assembled member flip; step-7 record_qa_url is URL-only (no stage-advancing event). Both qa_deployed routes (deploy_qa:completed + qa_smoke:completed) now only reachable via qa_green!, after the flip. Not-green run stays at qa_deploying. Regression test pins the ordering. dor-check green (full-suite+rubocop@72673e5==HEAD tree, GitHub CI 4/4). Ready for Steffon qa-release sweep.

Sealed-bid sizing

Edit →

Alex (PM)

—

Avi (PO)

SMALL

Dev

SMALL

Actual

XL